wangbo edited a comment on pull request #8768: URL: https://github.com/apache/incubator-doris/pull/8768#issuecomment-1084465447
1 Timer itself has an overhead, I don't think we need so many Timer by default and collect it in Prod Env. We can use GenericTimer when we meet obvious performance bottleneck in Prod Env or Test Env. We'd better not add more timer than before. So I suggest you just add ```ShortPredEvalTime``` or using ```PredEvalTime``` to cover short and vec evaluation. For other Timer, you can disable it by default or using ```GeneralDebugTimer``` instead. 2 ```GeneralDebugTimer``` is open by default currently, I think we can disable it by default. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
