eldenmoon commented on code in PR #39022:
URL: https://github.com/apache/doris/pull/39022#discussion_r1721145951
##########
be/src/vec/data_types/convert_field_to_type.cpp:
##########
@@ -98,6 +98,10 @@ class FieldVisitorToStringSimple : public
StaticVisitor<String> {
LOG(FATAL) << "not implemeted";
__builtin_unreachable();
}
+ [[noreturn]] String operator()(const VariantMap& x) const {
+ LOG(FATAL) << "not implemeted";
Review Comment:
changed to throw exception， `FieldVisitorToStringSimple` is not used in our
paths
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
