yiguolei commented on code in PR #39581:
URL: https://github.com/apache/doris/pull/39581#discussion_r1722024926
##########
be/src/vec/columns/column_impl.h:
##########
@@ -42,8 +42,8 @@ void IColumn::append_data_by_selector_impl(MutablePtr& res,
const Selector& sele
"Size of selector: {} is larger than size of
column: {}",
selector.size(), num_rows);
}
-
- res->reserve(num_rows);
+ DCHECK_GE(end, begin);
+ res->reserve(end - begin);
Review Comment:
add comment here to explain why need using this variable to reserve memory
not using num rows
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
