freemandealer commented on code in PR #38811:
URL: https://github.com/apache/doris/pull/38811#discussion_r1722893170
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -206,7 +202,11 @@ Status BlockFileCache::initialize() {
Status BlockFileCache::initialize_unlocked(std::lock_guard<std::mutex>&
cache_lock) {
DCHECK(!_is_initialized);
_is_initialized = true;
- _storage = std::make_unique<FSFileCacheStorage>();
+ if (is_in_memory()) {
Review Comment:
> check the config::enable_in_memory_file_cache_storage instead of
introducing extra functions
the be config will be removed, and use the parse result of cache_base_path
instead
> BlockFileCache should not know whether the storage is in-memory or not.
> it is enough that the file cache storage knows what type it is.
It should. Storage is created by BlockFileCache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
