eldenmoon commented on code in PR #39468:
URL: https://github.com/apache/doris/pull/39468#discussion_r1724368346
##########
fe/fe-core/src/main/java/org/apache/doris/qe/PointQueryExecutor.java:
##########
@@ -208,21 +409,61 @@ public RowBatch getNext() throws Exception {
if (candidateBackends == null || candidateBackends.isEmpty()) {
return new RowBatch();
}
+ OlapTable olapTable = shortCircuitQueryContext.scanNode.getOlapTable();
+ List<Column> keyColumns = olapTable.getBaseSchemaKeyColumns();
+ for (int i = 0; i < keyColumns.size(); ++i) {
+ Column column = keyColumns.get(i);
+ if (olapTable.isDistributionColumn(column.getName())) {
+ distributionKeyColumns.add(i);
+ } else if (olapTable.isPartitionColumn(column.getName())) {
+ partitionKeyColumns.add(i);
+ }
+ }
Iterator<Backend> backendIter = candidateBackends.iterator();
- RowBatch rowBatch = null;
+ RowBatch rowBatch = new RowBatch();
int tryCount = 0;
int maxTry = Math.min(Config.max_point_query_retry_time,
candidateBackends.size());
Status status = new Status();
+ this.allKeyTuples = addAllKeyTuples(keyColumns);
+ TResultBatch resultBatch = new TResultBatch();
+ resultBatch.setRows(Lists.newArrayList());
+ List<byte[]> batchSerialResult = Lists.newArrayList();
do {
Backend backend = backendIter.next();
- rowBatch = getNextInternal(status, backend);
- if (rowBatch != null) {
- break;
+ List<byte[]> subSerialResult = batchGetNext(status, backend);
+ if (subSerialResult == null) {
+ continue;
}
+ batchSerialResult.addAll(subSerialResult);
if (++tryCount >= maxTry) {
break;
}
- } while (true);
+ } while (backendIter.hasNext());
+ distributionKeys2TabletID.clear();
Review Comment:
should not clear here it's wrong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
