dataroaring opened a new pull request #8831: URL: https://github.com/apache/incubator-doris/pull/8831
When I builded doris be with ubsan enabled and enabled vectorization, be core dump at doris::DecimalV2Value::operator long(). It cored because accessing on a non-aligned address by sse. With ubsan enabled, compile generates different assemble code including sse instruction. A sender serializes tuples to a continugous memory area, while a recver just copy it. So we should align each tuple offset to 16 bytes. For compatibility, we should use a config to control it. BTW: with tools like ubsan, asan, tsan we can find bugs more easily, e.g. https://github.com/apache/incubator-doris/issues/8815. It is difficult to find the bug without ubsan. Anyway, we should use mordern tools to be more productivity. # Proposed changes Issue Number: close #8830 ## Problem Summary: Describe the overview of changes. ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 3. Has document been added or modified: (Yes/No/No Need) 4. Does it need to update dependencies: (Yes/No) 5. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [[email protected]](mailto:[email protected]) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
