morningman commented on code in PR #8838:
URL: https://github.com/apache/incubator-doris/pull/8838#discussion_r843406592
##########
fe/fe-core/src/main/java/org/apache/doris/analysis/SlotRef.java:
##########
@@ -74,9 +74,6 @@ public SlotRef(SlotDescriptor desc) {
this.type = desc.getType();
// TODO(zc): label is meaningful
this.label = null;
- if (this.type.equals(Type.CHAR)) {
Review Comment:
If it is unknown, better not modify it. Or it is very hard to track.
And please do not do 'bug fix' in this PR, because the title of this PR is
`[fix](ut)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
