This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 96a0f8d9b62 [fix](backup) Read db name from BackupJobInfo (#39855)
96a0f8d9b62 is described below
commit 96a0f8d9b629429bf3ca125ff67bbd40dde76806
Author: walter <[email protected]>
AuthorDate: Sat Aug 24 18:30:50 2024 +0800
[fix](backup) Read db name from BackupJobInfo (#39855)
PR #37412 read the db name from BackupMeta, but it is not compatible,
since BackupMeta is not serialized to json.
---
.../src/main/java/org/apache/doris/backup/BackupJob.java | 2 +-
.../src/main/java/org/apache/doris/backup/BackupMeta.java | 11 +----------
.../src/main/java/org/apache/doris/backup/RestoreJob.java | 4 ++--
.../test/java/org/apache/doris/backup/BackupHandlerTest.java | 2 +-
.../src/test/java/org/apache/doris/backup/RestoreJobTest.java | 2 +-
5 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
index 4cd3bbf8a24..6f73334f0c2 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupJob.java
@@ -523,7 +523,7 @@ public class BackupJob extends AbstractJob {
}
}
- backupMeta = new BackupMeta(db.getName(), copiedTables,
copiedResources);
+ backupMeta = new BackupMeta(copiedTables, copiedResources);
// send tasks
for (AgentTask task : batchTask.getAllTasks()) {
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupMeta.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupMeta.java
index 56513e244d3..0f1a043bdad 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/BackupMeta.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/BackupMeta.java
@@ -44,9 +44,6 @@ import java.util.List;
import java.util.Map;
public class BackupMeta implements Writable, GsonPostProcessable {
- @SerializedName(value = "db")
- private String dbName;
-
// tbl name -> tbl
@SerializedName(value = "tblNameMap")
private Map<String, Table> tblNameMap = Maps.newHashMap();
@@ -59,9 +56,7 @@ public class BackupMeta implements Writable,
GsonPostProcessable {
private BackupMeta() {
}
- public BackupMeta(String dbName, List<Table> tables, List<Resource>
resources) {
- this.dbName = dbName;
-
+ public BackupMeta(List<Table> tables, List<Resource> resources) {
for (Table table : tables) {
tblNameMap.put(table.getName(), table);
tblIdMap.put(table.getId(), table);
@@ -71,10 +66,6 @@ public class BackupMeta implements Writable,
GsonPostProcessable {
}
}
- public String getDbName() {
- return dbName;
- }
-
public Map<String, Table> getTables() {
return tblNameMap;
}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
b/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
index 5b2a2e7e822..7a29e6ff36b 100644
--- a/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
+++ b/fe/fe-core/src/main/java/org/apache/doris/backup/RestoreJob.java
@@ -764,7 +764,7 @@ public class RestoreJob extends AbstractJob implements
GsonPostProcessable {
}
// reset all ids in this table
- String srcDbName = backupMeta.getDbName();
+ String srcDbName = jobInfo.dbName;
Status st = remoteOlapTbl.resetIdsForRestore(env, db,
replicaAlloc, reserveReplica, srcDbName);
if (!st.ok()) {
status = st;
@@ -801,7 +801,7 @@ public class RestoreJob extends AbstractJob implements
GsonPostProcessable {
return;
}
} else {
- String srcDbName = backupMeta.getDbName();
+ String srcDbName = jobInfo.dbName;
remoteView.resetIdsForRestore(env, srcDbName,
db.getFullName());
restoredTbls.add(remoteView);
}
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/backup/BackupHandlerTest.java
b/fe/fe-core/src/test/java/org/apache/doris/backup/BackupHandlerTest.java
index 1cc05e3d4e6..ba564599029 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/backup/BackupHandlerTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/backup/BackupHandlerTest.java
@@ -213,7 +213,7 @@ public class BackupHandlerTest {
List<Table> tbls = Lists.newArrayList();
tbls.add(tbl);
List<Resource> resources = Lists.newArrayList();
- BackupMeta backupMeta = new BackupMeta(null, tbls, resources);
+ BackupMeta backupMeta = new BackupMeta(tbls, resources);
Map<Long, SnapshotInfo> snapshotInfos = Maps.newHashMap();
for (Partition part : tbl.getPartitions()) {
for (MaterializedIndex idx :
part.getMaterializedIndices(IndexExtState.VISIBLE)) {
diff --git
a/fe/fe-core/src/test/java/org/apache/doris/backup/RestoreJobTest.java
b/fe/fe-core/src/test/java/org/apache/doris/backup/RestoreJobTest.java
index 7ab6317e033..43eb00e3807 100644
--- a/fe/fe-core/src/test/java/org/apache/doris/backup/RestoreJobTest.java
+++ b/fe/fe-core/src/test/java/org/apache/doris/backup/RestoreJobTest.java
@@ -261,7 +261,7 @@ public class RestoreJobTest {
List<Table> tbls = Lists.newArrayList();
List<Resource> resources = Lists.newArrayList();
tbls.add(expectedRestoreTbl);
- backupMeta = new BackupMeta(null, tbls, resources);
+ backupMeta = new BackupMeta(tbls, resources);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
