BiteTheDDDDt commented on code in PR #8766:
URL: https://github.com/apache/incubator-doris/pull/8766#discussion_r844586771
##########
be/src/vec/exprs/table_function/vexplode.h:
##########
@@ -43,4 +47,13 @@ class VExplodeTableFunction : public TableFunction {
size_t _pos;
};
+class VExplodeOuterTableFunction : public VExplodeTableFunction {
+public:
Review Comment:
You can use template specific on
`TableFunctionCreator<VExplodeTableFunction>` to reduce a class
`VExplodeOuterTableFunction` just like
`TableFunctionCreator<VExplodeJsonArrayTableFunction>`.
And so that we can have a unified design style.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
