github-actions[bot] commented on code in PR #39979:
URL: https://github.com/apache/doris/pull/39979#discussion_r1732308489
##########
be/src/olap/storage_engine.h:
##########
@@ -235,6 +235,8 @@ class StorageEngine {
int64_t memory_limitation_bytes_per_thread_for_schema_change() const;
+ int64_t
memory_limitation_bytes_per_thread_for_schema_change_internal_sorting() const;
Review Comment:
warning: function
'memory_limitation_bytes_per_thread_for_schema_change_internal_sorting' should
be marked [[nodiscard]] [modernize-use-nodiscard]
```suggestion
[[nodiscard]] int64_t
memory_limitation_bytes_per_thread_for_schema_change_internal_sorting() const;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
