HappenLee commented on code in PR #8872:
URL: https://github.com/apache/incubator-doris/pull/8872#discussion_r844747358
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -157,7 +157,30 @@ class VecDateTimeValue { // Now this type is a temp
solution with little changes
_month(0), // so this is a difference between Vectorization mode
and Rowbatch mode with DateTimeValue;
_year(0) {} // before int128 16 bytes ---> after int64 8 bytes
- explicit VecDateTimeValue(int64_t t) { from_date_int64(t); }
+ static VecDateTimeValue create_from_olap_date(uint64_t value) {
Review Comment:
add comment what's the different between `create_from_olap_datetime` and
`create_from_normal_datetime`. it is default to know the different from the
name of function name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
