This is an automated email from the ASF dual-hosted git repository.
dataroaring pushed a commit to branch branch-3.0
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-3.0 by this push:
new 0acf2772ca2 [fix](cloud-mow) FE should not request partition stats by
snapshot read in calcDeleteBitmapForMow (#39791)
0acf2772ca2 is described below
commit 0acf2772ca2363df34a9c4fae02108688eb02410
Author: zhannngchen <[email protected]>
AuthorDate: Wed Aug 28 15:31:19 2024 +0800
[fix](cloud-mow) FE should not request partition stats by snapshot read in
calcDeleteBitmapForMow (#39791)
## Proposed changes
Issue Number: close #xxx
#37670 Let FE call get_delete_bitmap_update_lock in
calcDeleteBitmapForMow to get the latest compaction stats of the
corresponding partition at the same time, so that in the downstream
calcDelete bitmap task, it can let BE determine if there is a concurrent
compaction conflict.
However, this PR uses snapshot read when fetching the partition stats,
which makes it possible for us to fetch outdated stats, thus allowing
the BE to miss the conflict processing of concurrent compaction, and
generating duplicate keys.
---
cloud/src/meta-service/meta_service.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cloud/src/meta-service/meta_service.cpp
b/cloud/src/meta-service/meta_service.cpp
index d9f71ac2218..2213bb48387 100644
--- a/cloud/src/meta-service/meta_service.cpp
+++ b/cloud/src/meta-service/meta_service.cpp
@@ -1960,7 +1960,7 @@ void
MetaServiceImpl::get_delete_bitmap_update_lock(google::protobuf::RpcControl
for (const auto& tablet_index : request->tablet_indexes()) {
TabletIndexPB idx(tablet_index);
TabletStatsPB tablet_stat;
- internal_get_tablet_stats(code, msg, txn.get(), instance_id, idx,
tablet_stat, true);
+ internal_get_tablet_stats(code, msg, txn.get(), instance_id, idx,
tablet_stat, false);
if (code != MetaServiceCode::OK) {
response->clear_base_compaction_cnts();
response->clear_cumulative_compaction_cnts();
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
