morningman commented on PR #8895: URL: https://github.com/apache/incubator-doris/pull/8895#issuecomment-1091706577
Hi @mrhhsg , thanks for your contribution. 2 suggestions: 1. This is a good and important feature for Doris, better to make a [DSIP](https://cwiki.apache.org/confluence/display/DORIS/Doris+Improvement+Proposals) for it. 2. You can separate the PR into 2 steps. One is for adding thirdparty dependency, the other is the LLVM codegen itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
