github-actions[bot] commented on code in PR #39992:
URL: https://github.com/apache/doris/pull/39992#discussion_r1734475160
##########
be/src/runtime/routine_load/routine_load_task_executor.cpp:
##########
@@ -311,6 +312,19 @@ Status RoutineLoadTaskExecutor::submit_task(const
TRoutineLoadTask& task) {
}
}
+bool RoutineLoadTaskExecutor::_reach_memory_limit() {
+ bool is_exceed_soft_mem_limit =
GlobalMemoryArbitrator::is_exceed_soft_mem_limit();
+ auto current_load_mem_value =
+
MemTrackerLimiter::TypeMemSum[MemTrackerLimiter::Type::LOAD]->current_value();
+ if (is_exceed_soft_mem_limit || current_load_mem_value > _load_mem_limit) {
+ LOG(INFO) << "is_exceed_soft_mem_limit: " << is_exceed_soft_mem_limit
+ << " current_load_mem_value: " << current_load_mem_value
+ << " _load_mem_limit: " << _load_mem_limit;
+ return true;
Review Comment:
warning: redundant boolean literal in conditional return statement
[readability-simplify-boolean-expr]
be/src/runtime/routine_load/routine_load_task_executor.cpp:318:
```diff
- if (is_exceed_soft_mem_limit || current_load_mem_value >
_load_mem_limit) {
- LOG(INFO) << "is_exceed_soft_mem_limit: " <<
is_exceed_soft_mem_limit
- << " current_load_mem_value: " << current_load_mem_value
- << " _load_mem_limit: " << _load_mem_limit;
- return true;
- }
- return false;
+ return static_cast<bool>(is_exceed_soft_mem_limit ||
current_load_mem_value > _load_mem_limit);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
