lxr599 commented on code in PR #39468:
URL: https://github.com/apache/doris/pull/39468#discussion_r1734589834
##########
fe/fe-core/src/main/java/org/apache/doris/planner/HashDistributionPruner.java:
##########
@@ -119,9 +130,6 @@ public Collection<Long> prune(int columnId, PartitionKey
hashKey, int complex) {
Collection<Long> subList = prune(columnId + 1, hashKey,
newComplex);
resultSet.addAll(subList);
hashKey.popColumn();
- if (resultSet.size() >= bucketsList.size()) {
Review Comment:
In the case of `IN` query, we need to collect all the pruned buckets for the
data in the `IN list`. When `resultSet.size() >= bucketsList.size()` is `true`,
it is possible that only part of data in the `IN list` has been processed, that
is, the number of buckets is less than the length of `IN list`. So maybe we can
keep the `if`, and change it to this:
```c++
if ( isPointQuery() && resultSet.size() >= bucketsList.size()) {
break;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
