zingdle commented on code in PR #8849:
URL: https://github.com/apache/incubator-doris/pull/8849#discussion_r845254063
##########
fe/fe-core/src/main/java/org/apache/doris/mysql/privilege/PaloAuth.java:
##########
@@ -584,9 +584,13 @@ private void createUserInternal(UserIdentity userIdent,
String roleName, byte[]
throw new DdlException("Role: " + roleName + " does not
exist");
}
}
-
+
// 2. check if user already exist
if (userPrivTable.doesUserExist(userIdent)) {
+ if (ignoreIfExists) {
+ LOG.debug("user exists, ignored to create user: {}, is
replay: {}", userIdent, isReplay);
Review Comment:
@morningman Maybe this should be `LOG.info`, instead of changing all other
`LOG.info` to `LOG.debug`.
If we use `IF NOT EXISTS` but the user exists, we should be informed instead
of the message being swallowd.
The surrounding code sugguests using `LOG.info` (L623).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
