yiguolei commented on code in PR #40036:
URL: https://github.com/apache/doris/pull/40036#discussion_r1735494380
##########
be/src/pipeline/exec/analytic_sink_operator.h:
##########
@@ -82,14 +83,17 @@ class AnalyticSinkOperatorX final : public
DataSinkOperatorX<AnalyticSinkLocalSt
if (_partition_by_eq_expr_ctxs.empty()) {
return {ExchangeType::PASSTHROUGH};
} else if (_order_by_eq_expr_ctxs.empty()) {
- return _is_colocate && _require_bucket_distribution
+ return _is_colocate && _require_bucket_distribution &&
!_followed_by_shuffled_join
?
DataDistribution(ExchangeType::BUCKET_HASH_SHUFFLE, _partition_exprs)
: DataDistribution(ExchangeType::HASH_SHUFFLE,
_partition_exprs);
}
return
DataSinkOperatorX<AnalyticSinkLocalState>::required_data_distribution();
}
bool require_data_distribution() const override { return true; }
+ bool require_shuffled_data_distribution() const override {
+ return !_partition_by_eq_expr_ctxs.empty() &&
_order_by_eq_expr_ctxs.empty();
Review Comment:
OperatorX ---> local shuffle ---> join probe
OperatorBase
1. require_bucket_distribution
2. followed_by_shuffled_join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
