github-actions[bot] commented on code in PR #40132:
URL: https://github.com/apache/doris/pull/40132#discussion_r1736057917
##########
be/src/vec/sink/writer/vtablet_writer.cpp:
##########
@@ -817,6 +817,13 @@ void VNodeChannel::_add_block_success_callback(const
PTabletWriterAddBlockResult
auto st = deserialize_thrift_msg(buf, &len, false, &tprofile);
if (st.ok()) {
_state->load_channel_profile()->update(tprofile);
+ auto load_chanel_profile = _state->load_channel_profile();
Review Comment:
warning: 'auto load_chanel_profile' can be declared as 'auto
*load_chanel_profile' [readability-qualified-auto]
```suggestion
auto *load_chanel_profile = _state->load_channel_profile();
```
##########
be/src/runtime/tablets_channel.h:
##########
@@ -119,6 +119,10 @@ class BaseTabletsChannel {
bool is_finished() const { return _state == kFinished; }
+ int64_t file_close_time() { return _file_close_time; }
Review Comment:
warning: method 'file_close_time' can be made const
[readability-make-member-function-const]
```suggestion
int64_t file_close_time() const { return _file_close_time; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
