yiguolei commented on code in PR #8900:
URL: https://github.com/apache/incubator-doris/pull/8900#discussion_r845757488
##########
be/src/common/status.h:
##########
@@ -151,8 +155,18 @@ class Status {
return Status(TStatusCode::DATA_QUALITY_ERROR, msg, precise_code,
msg2);
}
+ // A wrapper for OLAPStatus
+ // Precise code is for OLAPStatus's enum value
+ // All Status Error is treated as Internal Error
+ static Status OLAPInternalError(int16_t precise_code, const Slice& msg =
Slice()) {
+ #ifdef PRINT_ALL_ERR_STATUS_STACKTRACE
+ LOG(WARNING) << "Error occurred, error code = " << precise_code << ",
with message: " << msg
+ << "\n" << boost::stacktrace::stacktrace();
Review Comment:
@xinyiZzz Currently, I won't implement this feature in Doris, because it
depends on unify the error code work.
I will do following task after this PR is closed:
1. Replace OLAPStatus with Status
2. Unify ErrorCode, for example TStatusCode, OLAPStatus, PStatus, I will
unify them to only one error code
3. Do some statistics on ErrorCodes, for example, we could find how many IO
Error happens.
4. After all these 3 tasks are finished, I think maybe we could implement
OmitStackTraceInFastThrow. But I am not sure because it will ignore some errors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
