EmmyMiao87 commented on code in PR #8927:
URL: https://github.com/apache/incubator-doris/pull/8927#discussion_r846019588


##########
new-docs/en/data-table/data-partition.md:
##########
@@ -209,9 +212,46 @@ It is also possible to use only one layer of partitioning. 
When using a layer pa
             
             > A new void appeared: [2017-01-01, 2017-02-01)
         
+
     In summary, the deletion of a partition does not change the scope of an 
existing partition. There may be holes in deleting partitions. When a partition 
is added by the `VALUES LESS THAN` statement, the lower bound of the partition 
immediately follows the upper bound of the previous partition.
+
+    In addition to the single-column partitioning we have seen above, Range 
partition also supports **multi-column partitioning**, examples are as follows:
+
+    ~~~text
+    ```

Review Comment:
   ```suggestion
       ```text
   ```



##########
new-docs/en/data-table/hit-the-rollup.md:
##########
@@ -26,20 +26,164 @@ under the License.
 
 # Rollup and query
 
+ROLLUP in multidimensional analysis means "scroll up", which means that data 
is aggregated further at a specified granularity.
+
+### Basic concepts
+
+In Doris, we make the table created by the user through the table building 
statement a Base table. Base table holds the basic data stored in the way 
specified by the user's table-building statement.
+
+On top of the Base table, we can create any number of ROLLUP tables. These 
ROLLUP data are generated based on the Base table and physically **stored 
independently**.
+
+The basic function of ROLLUP tables is to obtain coarser aggregated data on 
the basis of Base tables.
+
+Let's illustrate the ROLLUP tables and their roles in different data models 
with examples.
+
+#### ROLLUP in Aggregate Model and Uniq Model
+
+Because Uniq is only a special case of the Aggregate model, we do not 
distinguish it here.
+
+Example 1: Get the total consumption per user
+
+Following [Data Model Aggregate Model](data-model.html#Aggregate Model) in the 
**Aggregate Model** section, the Base table structure is as follows:
+
+| ColumnName      | Type         | AggregationType | Comment                   
             |
+| --------------- | ------------ | --------------- | 
-------------------------------------- |
+| user_id         | LARGEINT     |                 | user id                   
             |
+| date            | DATE         |                 | date of data filling      
             |
+| Time stamp      | DATETIME     |                 | Data filling time, 
accurate to seconds |
+| City            | VARCHAR (20) |                 | User City                 
             |
+| age             | SMALLINT     |                 | User age                  
             |
+| sex             | TINYINT      |                 | User gender               
             |
+| Last_visit_date | DATETIME     | REPLACE         | Last user access time     
             |
+| Cost            | BIGINT       | SUM             | Total User Consumption    
             |
+| max dwell time  | INT          | MAX             | Maximum user residence 
time            |
+| min dwell time  | INT          | MIN             | User minimum residence 
time            |
+
+The data stored are as follows:
+
+| user_id | date       | timestamp           | city      | age  | sex  | 
last\_visit\_date   | cost | max\_dwell\_time | min\_dwell\_time |
+| ------- | ---------- | ------------------- | --------- | ---- | ---- | 
------------------- | ---- | ---------------- | ---------------- |
+| 10000   | 2017-10-01 | 2017-10-01 08:00:05 | Beijing   | 20   | 0    | 
2017-10-01 06:00    | 20   | 10               | 10               |
+| 10000   | 2017-10-01 | 2017-10-01 09:00:05 | Beijing   | 20   | 0    | 
2017-10-01 07:00    | 15   | 2                | 2                |
+| 10001   | 2017-10-01 | 2017-10-01 18:12:10 | Beijing   | 30   | 1    | 
2017-10-01 17:05:45 | 2    | 22               | 22               |
+| 10002   | 2017-10-02 | 2017-10-02 13:10:00 | Shanghai  | 20   | 1    | 
2017-10-02 12:59:12 | 200  | 5                | 5                |
+| 10003   | 2017-10-02 | 2017-10-02 13:15:00 | Guangzhou | 32   | 0    | 
2017-10-02 11:20:00 | 30   | 11               | 11               |
+| 10004   | 2017-10-01 | 2017-10-01 12:12:48 | Shenzhen  | 35   | 0    | 
2017-10-01 10:00:15 | 100  | 3                | 3                |
+| 10004   | 2017-10-03 | 2017-10-03 12:38:20 | Shenzhen  | 35   | 0    | 
2017-10-03 10:20:22 | 11   | 6                | 6                |
+
+On this basis, we create a ROLLUP:
+
+| ColumnName |
+| ---------- |
+| user_id    |

Review Comment:
   ```suggestion
   | user\_id    |
   ```



##########
new-docs/en/data-table/data-partition.md:
##########
@@ -209,9 +212,46 @@ It is also possible to use only one layer of partitioning. 
When using a layer pa
             
             > A new void appeared: [2017-01-01, 2017-02-01)
         
+
     In summary, the deletion of a partition does not change the scope of an 
existing partition. There may be holes in deleting partitions. When a partition 
is added by the `VALUES LESS THAN` statement, the lower bound of the partition 
immediately follows the upper bound of the previous partition.
+
+    In addition to the single-column partitioning we have seen above, Range 
partition also supports **multi-column partitioning**, examples are as follows:
+
+    ~~~text

Review Comment:
   Remove it



##########
new-docs/en/data-table/advance-usage.md:
##########
@@ -28,9 +28,9 @@ under the License.
 
 Here we introduce some of Doris's advanced features.
 
-## Table 1 Structural Change
+## Table  Structural Change

Review Comment:
   ```suggestion
   ## Table Structural Change
   ```



##########
new-docs/en/data-table/data-partition.md:
##########
@@ -244,7 +284,38 @@ It is also possible to use only one layer of partitioning. 
When using a layer pa
             p_uk: ("London")
             ```
 
-    You cannot add partitions with overlapping ranges.
+    List partition also supports **multi-column partition**, examples are as 
follows:
+
+    ~~~text

Review Comment:
   same as above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to