zbtzbtzbt opened a new pull request, #8933: URL: https://github.com/apache/incubator-doris/pull/8933
# Proposed changes I found too much inline in doris, some are useless so, this pr is for remove useless keyword `inline` 1. Member functions defined in a class are `inline` by default (implicitly), and do not need to be added 2. `inline` is a keyword used for **implementation**, which has no effect when placed before the function declaration ----- A coding standard from LLVM coding ducument: <img width="864" alt="inline1" src="https://user-images.githubusercontent.com/35688959/162446749-681a3fcf-4c5b-411c-a361-b1df8b3bd2a6.png";> Reference: https://isocpp.org/wiki/faq/inline-functions#where-to-put-inline-keyword https://stackoverflow.com/questions/7762731/whats-the-difference-between-static-and-static-inline-function https://llvm.org/docs/CodingStandards.html @morningman @yangzhg @HappenLee @caiconghui ## Checklist(Required) 1. Does it affect the original behavior: (Yes/No/I Don't know) 2. Has unit tests been added: (Yes/No/No Need) 4. Has document been added or modified: (Yes/No/No Need) 5. Does it need to update dependencies: (Yes/No) 6. Are there any changes that cannot be rolled back: (Yes/No) ## Further comments If this is a relatively large or complex change, kick off the discussion at [[email protected]](mailto:[email protected]) by explaining why you chose the solution you did and what alternatives you considered, etc... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/35688959/162446749-681a3fcf-4c5b-411c-a361-b1df8b3bd2a6.png"](https://user-images.githubusercontent.com/35688959/162446749-681a3fcf-4c5b-411c-a361-b1df8b3bd2a6.png"){kind=link}