github-actions[bot] commented on code in PR #40230: URL: https://github.com/apache/doris/pull/40230#discussion_r1740146656
########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/disjunction.h: ########## @@ -0,0 +1,31 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class Disjunction { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t next_doc() const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/phrase_query.h: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class PhraseQuery { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t next_doc() const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/disjunction.h: ########## @@ -0,0 +1,31 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class Disjunction { +public: + inline int32_t doc_id() const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t doc_id() const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/clause.h: ########## @@ -0,0 +1,44 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <CLucene.h> // IWYU pragma: keep Review Comment: warning: 'CLucene.h' file not found [clang-diagnostic-error] ```cpp #include <CLucene.h> // IWYU pragma: keep ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/disjunction.h: ########## @@ -0,0 +1,31 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class Disjunction { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } + + inline int32_t advance(int32_t target) const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t advance(int32_t target) const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/disjunction.h: ########## @@ -0,0 +1,31 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class Disjunction { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } + + inline int32_t advance(int32_t target) const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t advance(int32_t target) const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/phrase_query.h: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class PhraseQuery { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } + + inline int32_t advance(int32_t target) const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t advance(int32_t target) const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/phrase_query.h: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class PhraseQuery { +public: + inline int32_t doc_id() const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t doc_id() const { return -1; } ^ ``` ########## be/src/olap/rowset/segment_v2/inverted_index/query_v2/phrase_query.h: ########## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +namespace doris::segment_v2::idx_query_v2 { + +class PhraseQuery { +public: + inline int32_t doc_id() const { return -1; } + + inline int32_t next_doc() const { return -1; } + + inline int32_t advance(int32_t target) const { return -1; } Review Comment: warning: unknown type name 'int32_t' [clang-diagnostic-error] ```cpp inline int32_t advance(int32_t target) const { return -1; } ^ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
