qidaye commented on code in PR #8808:
URL: https://github.com/apache/incubator-doris/pull/8808#discussion_r846913679
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/DataProperty.java:
##########
@@ -95,14 +138,20 @@ public boolean equals(Object obj) {
DataProperty other = (DataProperty) obj;
return this.storageMedium == other.storageMedium
- && this.cooldownTimeMs == other.cooldownTimeMs;
+ && this.coolDownTimeMs == other.coolDownTimeMs
+ && this.remoteCoolDownTimeMs == other.remoteCoolDownTimeMs
+ &&
this.remoteStorageResourceName.equals(other.remoteStorageResourceName)
+ && this.remoteStorageMedium == other.remoteStorageMedium;
Review Comment:
The remote storage medium is a redundant design to make it easier to get to
the remote storage medium without having to fetch it from the resource manager
every time.
It is mainly used to determine the storage media that may be needed several
times during the process of converting hot data to cold data.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
