yujun777 commented on code in PR #40264:
URL: https://github.com/apache/doris/pull/40264#discussion_r1751155461
##########
docker/runtime/doris-compose/cluster.py:
##########
@@ -450,13 +461,25 @@ def get_add_init_config(self):
cfg += self.cluster.be_config
if self.cluster.is_cloud:
cfg += [
- "cloud_unique_id = " + self.cloud_unique_id(),
- "meta_service_endpoint = {}".format(
- self.cluster.get_meta_server_addr()),
'tmp_file_dirs = [
{"path":"./storage/tmp","max_cache_bytes":10240000,
"max_upload_bytes":10240000}]',
'enable_file_cache = true',
'file_cache_path = [ {{"path": "{}/storage/file_cache",
"total_size":53687091200, "query_limit": 10737418240}}]'
.format(self.docker_home_dir()),
+ "deploy_mode = disaggregated",
+ ]
+
+ if self.cluster.is_cloud and not
self.cluster.no_be_metaservice_endpoint:
Review Comment:
462 行已经已经有 self.cluster.is_cloud 的判断了。 重构471 ~ 483 行，
把这部分的self.cluster.is_cloud 删掉， 并把它们放到 462 行下的block 中
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
