jackwener commented on code in PR #8980:
URL: https://github.com/apache/incubator-doris/pull/8980#discussion_r850163962
##########
fe/fe-core/src/test/java/org/apache/doris/rewrite/InferFiltersRuleTest.java:
##########
@@ -299,4 +299,25 @@ public void testWhereBetweenPredicate() throws Exception {
Assert.assertTrue(planString.contains("`tb2`.`k1` >= 1"));
Assert.assertTrue(planString.contains("`tb2`.`k1` <= 2"));
}
+
+ @Test
Review Comment:
infer just occurs when predicate can pushdown. I think this point should be
included in unit test.
We should add `failed to infer predicate when can't pushdown` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
