zhiqiang-hhhh commented on code in PR #40567:
URL: https://github.com/apache/doris/pull/40567#discussion_r1757119823
##########
be/src/vec/functions/function_string.h:
##########
@@ -2642,6 +2632,53 @@ class FunctionUrlDecode : public IFunction {
}
};
+class FunctionUrlEncode : public IFunction {
+public:
+ static constexpr auto name = "url_encode";
+ static FunctionPtr create() { return
std::make_shared<FunctionUrlEncode>(); }
+ String get_name() const override { return name; }
+ size_t get_number_of_arguments() const override { return 1; }
+ bool is_variadic() const override { return false; }
+
+ DataTypePtr get_return_type_impl(const DataTypes& arguments) const
override {
+ return std::make_shared<DataTypeString>();
+ }
+
+ Status execute_impl(FunctionContext* context, Block& block, const
ColumnNumbers& arguments,
+ size_t result, size_t input_rows_count) const override
{
+ auto res = ColumnString::create();
+ auto& res_offsets = res->get_offsets();
+ auto& res_chars = res->get_chars();
+ res_offsets.resize(input_rows_count);
+
+ ColumnPtr argument_column =
+
block.get_by_position(arguments[0]).column->convert_to_full_column_if_const();
Review Comment:
`convert_to_full_column_if_const` is unnecessary. default_impl_for_const
will remove const property for you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
