github-actions[bot] commented on code in PR #40874:
URL: https://github.com/apache/doris/pull/40874#discussion_r1759708521
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -229,7 +231,8 @@ PipelinePtr
PipelineFragmentContext::add_pipeline(PipelinePtr parent, int idx) {
return pipeline;
}
-Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request) {
+Status PipelineFragmentContext::prepare(const doris::TPipelineFragmentParams&
request,
Review Comment:
warning: function 'prepare' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_fragment_context.cpp:233:** 124 lines including
whitespace and comments (threshold 80)
```cpp
^
```
</details>
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -355,17 +358,23 @@
return Status::OK();
}
-Status PipelineFragmentContext::_build_pipeline_tasks(
- const doris::TPipelineFragmentParams& request) {
+Status PipelineFragmentContext::_build_pipeline_tasks(const
doris::TPipelineFragmentParams& request,
Review Comment:
warning: function '_build_pipeline_tasks' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_fragment_context.cpp:360:** 218 lines including
whitespace and comments (threshold 80)
```cpp
^
```
</details>
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -355,17 +358,23 @@
return Status::OK();
}
-Status PipelineFragmentContext::_build_pipeline_tasks(
- const doris::TPipelineFragmentParams& request) {
+Status PipelineFragmentContext::_build_pipeline_tasks(const
doris::TPipelineFragmentParams& request,
Review Comment:
warning: function '_build_pipeline_tasks' has cognitive complexity of 56
(threshold 50) [readability-function-cognitive-complexity]
```cpp
^
```
<details>
<summary>Additional context</summary>
**be/src/pipeline/pipeline_fragment_context.cpp:373:** nesting level
increased to 1
```cpp
);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:378:** nesting level
increased to 2
```cpp
gr;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:384:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:387:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:390:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:393:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:396:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:501:** nesting level
increased to 2
```cpp
te
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:503:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
]);
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:503:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
]);
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:542:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
};
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:549:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
0;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:550:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
) {
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:550:** nesting level
increased to 4
```cpp
) {
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:555:** +5, including nesting
penalty of 4, nesting level increased to 5
```cpp
++;
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:550:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
) {
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:561:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
m);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:563:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
k);
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:564:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
) {
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:569:** +1, nesting level
increased to 1
```cpp
}
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:570:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
e {
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:571:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
) {
^
```
**be/src/common/status.h:628:** expanded from macro 'RETURN_IF_ERROR'
```cpp
do { \
^
```
**be/src/pipeline/pipeline_fragment_context.cpp:571:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
) {
^
```
**be/src/common/status.h:630:** expanded from macro 'RETURN_IF_ERROR'
```cpp
if (UNLIKELY(!_status_.ok())) { \
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
