HappenLee commented on code in PR #40710:
URL: https://github.com/apache/doris/pull/40710#discussion_r1764258585
##########
be/src/vec/functions/function_string.h:
##########
@@ -2251,6 +2221,34 @@ class FunctionSplitByString : public IFunction {
}
return pos - old_size;
}
+
+ void split_empty_delimiter(const StringRef& str_ref, ColumnString::Chars&
column_string_chars,
+ ColumnString::Offsets& column_string_offsets,
+ NullMapType* dest_nested_null_map,
ColumnArray::Offset64& string_pos,
+ ColumnArray::Offset64& dest_pos) const {
+ const size_t old_size = column_string_chars.size();
+ const size_t new_size = old_size + str_ref.size;
+ column_string_chars.resize(new_size);
+ memcpy(column_string_chars.data() + old_size, str_ref.data,
str_ref.size);
+ if (simd::VStringFunctions::is_ascii(str_ref)) {
Review Comment:
better `std::iota + resize` do faster work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
