seawinde commented on code in PR #40658:
URL: https://github.com/apache/doris/pull/40658#discussion_r1764327829


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/info/CreateMTMVInfo.java:
##########
@@ -195,6 +197,16 @@ public void analyze(ConnectContext ctx) throws Exception {
         rewriteQuerySql(ctx);
     }
 
+    /**validate column name*/
+    public void validateColumns(List<ColumnDefinition> columns) throws 
UserException {
+        Set<String> colSets = Sets.newTreeSet(String.CASE_INSENSITIVE_ORDER);
+        for (ColumnDefinition col : columns) {
+            if (!colSets.add(col.getName())) {

Review Comment:
   Yeah,already have the logic to check invalid caracter in column name, and 
move the check invalid caracter logic to method `validateColumns`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to