This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new fbed56639c2 [fix](compaction) catch exception in compaction (#40900)
(#40930)
fbed56639c2 is described below
commit fbed56639c28fc1d582cc41abb7316286fa2eaa9
Author: Jerry Hu <[email protected]>
AuthorDate: Thu Sep 19 01:08:34 2024 +0800
[fix](compaction) catch exception in compaction (#40900) (#40930)
## Proposed changes
pick #40900
```
terminate called after throwing an instance of 'doris::Exception'
{color:red} what(): [E6] Too large string size.{color}
0# doris::Exception::Exception(int, std::basic_string_view<char,
std::char_traits<char> > const&) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:173
1#
doris::vectorized::read_string_binary(std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >&,
doris::vectorized::BufferReadable&, unsigned long) at
/root/doris_branch-2.1/doris/be/src/vec/io/io_helper.h:177
2#
doris::vectorized::IAggregateFunctionHelper<doris::vectorized::AggregateFunctionNullUnaryInline<doris::vectorized::AggregateFunctionGroupConcat<doris::vectorized::AggregateFunctionGroupConcatImplStr>,
true> >::deserialize_and_merge_from_column_range(char*,
doris::vectorized::IColumn const&, unsigned long, unsigned long,
doris::vectorized::Arena*) const at
/root/doris_branch-2.1/doris/be/src/vec/aggregate_functions/aggregate_function.h:0
3#
doris::vectorized::IAggregateFunctionHelper<doris::vectorized::AggregateStateUnion>::add_batch_range(unsigned
long, unsigned long, char*, doris::vectorized::IColumn const**,
doris::vectorized::Arena*, bool) at
/root/doris_branch-2.1/doris/be/src/vec/aggregate_functions/aggregate_function.h:0
4#
doris::vectorized::VerticalBlockReader::_update_agg_value(std::vector<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>,
std::allocator<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>
> >&, int, int, bool) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:326
5#
doris::vectorized::VerticalBlockReader::_update_agg_data(std::vector<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>,
std::allocator<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>
> >&) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:308
6#
doris::vectorized::VerticalBlockReader::_agg_key_next_block(doris::vectorized::Block*,
bool*) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:0
7#
doris::vectorized::VerticalBlockReader::next_block_with_aggregation(doris::vectorized::Block*,
bool*) at /root/doris_branch-2.1/doris/be/src/common/status.h:491
8#
doris::Merger::vertical_compact_one_group(std::shared_ptr<doris::Tablet>,
doris::ReaderType, std::shared_ptr<doris::TabletSchema>, bool,
std::vector<unsigned int, std::allocator<unsigned int> > const&,
doris::vectorized::RowSourcesBuffer*,
std::vector<std::shared_ptr<doris::RowsetReader>,
std::allocator<std::shared_ptr<doris::RowsetReader> > > const&,
doris::RowsetWriter*, long, doris::Merger::Statistics*, std::vector<unsigned
int, std::allocator<unsigned int> >, long, dor [...]
9#
doris::Merger::vertical_merge_rowsets(std::shared_ptr<doris::Tablet>,
doris::ReaderType, std::shared_ptr<doris::TabletSchema>,
std::vector<std::shared_ptr<doris::RowsetReader>,
std::allocator<std::shared_ptr<doris::RowsetReader> > > const&,
doris::RowsetWriter*, long, long, doris::Merger::Statistics*) at
/root/doris_branch-2.1/doris/be/src/olap/merger.cpp:445
10# doris::Compaction::do_compaction_impl(long) at
/root/doris_branch-2.1/doris/be/src/olap/compaction.cpp:385
11# doris::Compaction::do_compaction(long) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1291
12# doris::CumulativeCompaction::execute_compact_impl() at
/root/doris_branch-2.1/doris/be/src/common/status.h:491
13# doris::Compaction::execute_compact() at
/root/doris_branch-2.1/doris/be/src/common/status.h:491
14# doris::Tablet::execute_compaction(doris::Compaction&) at
/root/doris_branch-2.1/doris/be/src/common/status.h:491
15# std::_Function_handler<void (),
doris::StorageEngine::_submit_compaction_task(std::shared_ptr<doris::Tablet>,
doris::CompactionType, bool)::$_0>::_M_invoke(std::_Any_data const&) at
/root/doris_branch-2.1/doris/be/src/olap/olap_server.cpp:1018
16# doris::ThreadPool::dispatch_thread() at
/root/doris_branch-2.1/doris/be/src/util/threadpool.cpp:0
17# doris::Thread::supervise_thread(void*) at
/var/local/ldb-toolchain/bin/../usr/include/pthread.h:562
18# ?
19# ?
*** Query id: 0-0 ***
*** is nereids: 0 ***
*** tablet id: 38266341 ***
*** Aborted at 1726615633 (unix time) try "date -d @1726615633" if you are
using GNU date ***
*** Current BE git commitID: db06c678a3 ***
*** SIGABRT unknown detail explain (@0x26af02) received by PID 2535170 (TID
2536168 OR 0x7f48c81cd640) from PID 2535170; stack trace: ***
0# doris::signal::(anonymous namespace)::FailureSignalHandler(int,
siginfo_t*, void*) at
/root/doris_branch-2.1/doris/be/src/common/signal_handler.h:421
1# 0x00007F4AB18F8520 in /lib/x86_64-linux-gnu/libc.so.6
2# pthread_kill at ./nptl/pthread_kill.c:89
3# raise at ../sysdeps/posix/raise.c:27
4# abort at ./stdlib/abort.c:81
5# __gnu_cxx::__verbose_terminate_handler() [clone .cold] at
../../../../libstdc++-v3/libsupc++/vterminate.cc:75
6# __cxxabiv1::__terminate(void (*)()) at
../../../../libstdc++-v3/libsupc++/eh_terminate.cc:48
7# 0x000055C401EF7811 in /mnt/disk1/STRESS_ENV/be/lib/doris_be
8# 0x000055C401EF7964 in /mnt/disk1/STRESS_ENV/be/lib/doris_be
9# doris::vectorized::read_string_binary(std::__cxx11::basic_string<char,
std::char_traits<char>, std::allocator<char> >&,
doris::vectorized::BufferReadable&, unsigned long) at
/root/doris_branch-2.1/doris/be/src/vec/io/io_helper.h:180
10#
doris::vectorized::IAggregateFunctionHelper<doris::vectorized::AggregateFunctionNullUnaryInline<doris::vectorized::AggregateFunctionGroupConcat<doris::vectorized::AggregateFunctionGroupConcatImplStr>,
true> >::deserialize_and_merge_from_column_range(char*,
doris::vectorized::IColumn const&, unsigned long, unsigned long,
doris::vectorized::Arena*) const in /mnt/disk1/STRESS_ENV/be/lib/doris_be
11#
doris::vectorized::IAggregateFunctionHelper<doris::vectorized::AggregateStateUnion>::add_batch_range(unsigned
long, unsigned long, char*, doris::vectorized::IColumn const**,
doris::vectorized::Arena*, bool) in /mnt/disk1/STRESS_ENV/be/lib/doris_be
12#
doris::vectorized::VerticalBlockReader::_update_agg_value(std::vector<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>,
std::allocator<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>
> >&, int, int, bool) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:326
13#
doris::vectorized::VerticalBlockReader::_update_agg_data(std::vector<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>,
std::allocator<COW<doris::vectorized::IColumn>::mutable_ptr<doris::vectorized::IColumn>
> >&) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:308
14#
doris::vectorized::VerticalBlockReader::_agg_key_next_block(doris::vectorized::Block*,
bool*) in /mnt/disk1/STRESS_ENV/be/lib/doris_be
15#
doris::vectorized::VerticalBlockReader::next_block_with_aggregation(doris::vectorized::Block*,
bool*) at
/root/doris_branch-2.1/doris/be/src/vec/olap/vertical_block_reader.cpp:58
16#
doris::Merger::vertical_compact_one_group(std::shared_ptr<doris::Tablet>,
doris::ReaderType, std::shared_ptr<doris::TabletSchema>, bool,
std::vector<unsigned int, std::allocator<unsigned int> > const&,
doris::vectorized::RowSourcesBuffer*,
std::vector<std::shared_ptr<doris::RowsetReader>,
std::allocator<std::shared_ptr<doris::RowsetReader> > > const&,
doris::RowsetWriter*, long, doris::Merger::Statistics*, std::vector<unsigned
int, std::allocator<unsigned int> >, long, doris::Comp [...]
17# doris::Merger::vertical_merge_rowsets(std::shared_ptr<doris::Tablet>,
doris::ReaderType, std::shared_ptr<doris::TabletSchema>,
std::vector<std::shared_ptr<doris::RowsetReader>,
std::allocator<std::shared_ptr<doris::RowsetReader> > > const&,
doris::RowsetWriter*, long, long, doris::Merger::Statistics*) at
/root/doris_branch-2.1/doris/be/src/olap/merger.cpp:445
18# doris::Compaction::do_compaction_impl(long) at
/root/doris_branch-2.1/doris/be/src/olap/compaction.cpp:385
19# doris::Compaction::do_compaction(long) at
/root/doris_branch-2.1/doris/be/src/olap/compaction.cpp:136
20# doris::CumulativeCompaction::execute_compact_impl() at
/root/doris_branch-2.1/doris/be/src/olap/cumulative_compaction.cpp:79
21# doris::Compaction::execute_compact() at
/root/doris_branch-2.1/doris/be/src/olap/compaction.cpp:118
22# doris::Tablet::execute_compaction(doris::Compaction&) at
/root/doris_branch-2.1/doris/be/src/olap/tablet.cpp:2067
23# std::_Function_handler<void (),
doris::StorageEngine::_submit_compaction_task(std::shared_ptr<doris::Tablet>,
doris::CompactionType, bool)::$_0>::_M_invoke(std::_Any_data const&) at
/var/local/ldb-toolchain/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/std_function.h:291
24# doris::ThreadPool::dispatch_thread() in
/mnt/disk1/STRESS_ENV/be/lib/doris_be
25# doris::Thread::supervise_thread(void*) at
/root/doris_branch-2.1/doris/be/src/util/thread.cpp:499
26# start_thread at ./nptl/pthread_create.c:442
27# 0x00007F4AB19DC850 at ../sysdeps/unix/sysv/linux/x86_64/clone3.S:83
```
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
---
be/src/olap/tablet.cpp | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/olap/tablet.cpp b/be/src/olap/tablet.cpp
index d5d12c101f5..dede9f2600f 100644
--- a/be/src/olap/tablet.cpp
+++ b/be/src/olap/tablet.cpp
@@ -57,6 +57,7 @@
#include "agent/utils.h"
#include "common/config.h"
#include "common/consts.h"
+#include "common/exception.h"
#include "common/logging.h"
#include "common/signal_handler.h"
#include "common/status.h"
@@ -2059,8 +2060,7 @@ void Tablet::execute_compaction(Compaction& compaction) {
MonotonicStopWatch watch;
watch.start();
- Status res = compaction.execute_compact();
-
+ Status res = [&]() { RETURN_IF_CATCH_EXCEPTION({ return
compaction.execute_compact(); }); }();
if (!res.ok()) [[unlikely]] {
set_last_failure_time(this, compaction, UnixMillis());
LOG(WARNING) << "failed to do " << compaction.compaction_name()
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
