dataroaring commented on code in PR #38834:
URL: https://github.com/apache/doris/pull/38834#discussion_r1772460715
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java:
##########
@@ -139,35 +151,54 @@ public long getBackendId() {
if (LOG.isDebugEnabled()) {
LOG.debug("get cluster by context {}", cluster);
}
+ String clusterStatus = ((CloudSystemInfoService)
Env.getCurrentSystemInfo())
+ .getCloudStatusByName(cluster);
+ if (!Strings.isNullOrEmpty(clusterStatus)
+ && Cloud.ClusterStatus.valueOf(clusterStatus)
+ == Cloud.ClusterStatus.MANUAL_SHUTDOWN) {
+ LOG.warn("auto start cluster {} in manual shutdown
status", cluster);
+ throw new ComputeGroupException(
+ String.format("The current cluster %s has been
manually shutdown", cluster),
+
ComputeGroupException.FailedTypeEnum.CURRENT_COMPUTE_GROUP_BEEN_MANUAL_SHUTDOWN);
+ }
}
} else {
if (LOG.isDebugEnabled()) {
LOG.debug("connect context is null in getBackendId");
}
- return -1;
+ throw new ComputeGroupException("connect context not set",
+ ComputeGroupException.FailedTypeEnum.CONNECT_CONTEXT_NOT_SET);
}
return getBackendIdImpl(cluster);
}
- private long getBackendIdImpl(String cluster) {
+ private long getBackendIdImpl(String cluster) throws ComputeGroupException
{
// if cluster is SUSPENDED, wait
+ String wakeUPCluster = "";
try {
- cluster = ((CloudSystemInfoService)
Env.getCurrentSystemInfo()).waitForAutoStart(cluster);
+ wakeUPCluster = ((CloudSystemInfoService)
Env.getCurrentSystemInfo()).waitForAutoStart(cluster);
} catch (DdlException e) {
// this function cant throw exception. so just log it
LOG.warn("cant resume cluster {}, exception", cluster, e);
}
+ if (!Strings.isNullOrEmpty(wakeUPCluster) &&
!cluster.equals(wakeUPCluster)) {
+ cluster = wakeUPCluster;
+ LOG.warn("get backend input cluster {} useless, so auto start
choose a new one cluster {}",
Review Comment:
new compute group
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/catalog/CloudReplica.java:
##########
@@ -139,35 +151,54 @@ public long getBackendId() {
if (LOG.isDebugEnabled()) {
LOG.debug("get cluster by context {}", cluster);
}
+ String clusterStatus = ((CloudSystemInfoService)
Env.getCurrentSystemInfo())
+ .getCloudStatusByName(cluster);
+ if (!Strings.isNullOrEmpty(clusterStatus)
+ && Cloud.ClusterStatus.valueOf(clusterStatus)
+ == Cloud.ClusterStatus.MANUAL_SHUTDOWN) {
+ LOG.warn("auto start cluster {} in manual shutdown
status", cluster);
+ throw new ComputeGroupException(
+ String.format("The current cluster %s has been
manually shutdown", cluster),
+
ComputeGroupException.FailedTypeEnum.CURRENT_COMPUTE_GROUP_BEEN_MANUAL_SHUTDOWN);
+ }
}
} else {
if (LOG.isDebugEnabled()) {
LOG.debug("connect context is null in getBackendId");
}
- return -1;
+ throw new ComputeGroupException("connect context not set",
+ ComputeGroupException.FailedTypeEnum.CONNECT_CONTEXT_NOT_SET);
}
return getBackendIdImpl(cluster);
}
- private long getBackendIdImpl(String cluster) {
+ private long getBackendIdImpl(String cluster) throws ComputeGroupException
{
// if cluster is SUSPENDED, wait
+ String wakeUPCluster = "";
try {
- cluster = ((CloudSystemInfoService)
Env.getCurrentSystemInfo()).waitForAutoStart(cluster);
+ wakeUPCluster = ((CloudSystemInfoService)
Env.getCurrentSystemInfo()).waitForAutoStart(cluster);
} catch (DdlException e) {
// this function cant throw exception. so just log it
LOG.warn("cant resume cluster {}, exception", cluster, e);
}
+ if (!Strings.isNullOrEmpty(wakeUPCluster) &&
!cluster.equals(wakeUPCluster)) {
+ cluster = wakeUPCluster;
+ LOG.warn("get backend input cluster {} useless, so auto start
choose a new one cluster {}",
+ cluster, wakeUPCluster);
+ }
// check default cluster valid.
if (Strings.isNullOrEmpty(cluster)) {
LOG.warn("failed to get available be, clusterName: {}", cluster);
- return -1;
+ throw new ComputeGroupException("cluster name is empty",
Review Comment:
compute group name is empty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
