This is an automated email from the ASF dual-hosted git repository.
eldenmoon pushed a commit to branch branch-2.1
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-2.1 by this push:
new 78adf64353e [compability](variant) fix nullable serde during upgrading
to 3.0 (#41191)
78adf64353e is described below
commit 78adf64353e7eb811134abc4c871e49983b5b27f
Author: lihangyu <[email protected]>
AuthorDate: Tue Sep 24 19:44:54 2024 +0800
[compability](variant) fix nullable serde during upgrading to 3.0 (#41191)
need to check nullable during serialization when upgrading to 3.0
---
be/src/vec/columns/column_object.cpp | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/be/src/vec/columns/column_object.cpp
b/be/src/vec/columns/column_object.cpp
index 71ff45c02e6..8c139ba8fb5 100644
--- a/be/src/vec/columns/column_object.cpp
+++ b/be/src/vec/columns/column_object.cpp
@@ -1150,8 +1150,9 @@ Status find_and_set_leave_value(const IColumn* column,
const PathInData& path,
"failed to set value for path {}, expected type {}, but got {}
at row {}",
path.get_path(), type->get_name(), column->get_name(), row);
}
- const auto* nullable = assert_cast<const ColumnNullable*>(column);
- if (nullable->is_null_at(row) || (path.empty() &&
nullable->get_data_at(row).empty())) {
+ const auto* nullable = check_and_get_column<ColumnNullable>(column);
+ if (nullable != nullptr &&
+ (nullable->is_null_at(row) || (path.empty() &&
nullable->get_data_at(row).empty()))) {
return Status::OK();
}
// TODO could cache the result of leaf nodes with it's path info
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
