morningman commented on code in PR #40302:
URL: https://github.com/apache/doris/pull/40302#discussion_r1776806159


##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2784,6 +2784,10 @@ public class Config extends ConfigBase {
     @ConfField
     public static long spilled_profile_storage_limit_bytes = 1 * 1024 * 1024 * 
1024; // 1GB
 
+    // Profile will be spilled to storage after query has finished for this 
time.
+    @ConfField

Review Comment:
   add description field



##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2784,6 +2784,10 @@ public class Config extends ConfigBase {
     @ConfField
     public static long spilled_profile_storage_limit_bytes = 1 * 1024 * 1024 * 
1024; // 1GB
 
+    // Profile will be spilled to storage after query has finished for this 
time.
+    @ConfField

Review Comment:
   use `_second` as suffix, like other config item's name



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to