cambyzju commented on code in PR #9147:
URL: https://github.com/apache/incubator-doris/pull/9147#discussion_r855090552
##########
be/src/exprs/table_function/table_function_factory.cpp:
##########
@@ -92,14 +85,32 @@ const std::unordered_map<std::pair<std::string, bool>,
std::function<TableFuncti
{{"explode_json_array_string", true},
VExplodeJsonArrayStringCreator},
{{"explode_bitmap", true},
TableFunctionCreator<vectorized::VExplodeBitmapTableFunction>()},
- {{"explode", true}, VExplodeCreator},
- {{"explode_outer", true}, VExplodeOuterCreator}}; // namespace
doris
+ {{"explode", true},
TableFunctionCreator<vectorized::VExplodeTableFunction> {}}};
+
+Status TableFunctionFactory::get_fn(std::string fn_name, bool is_vectorized,
ObjectPool* pool,
+ TableFunction** fn) {
+ bool is_outer = false;
+
+ auto match_suffix = [](const std::string& name, const std::string& suffix)
-> bool {
+ return name.substr(name.length() - suffix.length()) == suffix;
Review Comment:
check length at first, maybe name.length() < suffix.length()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
