wangbo commented on code in PR #9167:
URL: https://github.com/apache/incubator-doris/pull/9167#discussion_r855955935
##########
be/src/vec/columns/column_dictionary.h:
##########
@@ -106,6 +107,7 @@ class ColumnDictionary final : public COWHelper<IColumn,
ColumnDictionary<T>> {
void clear() override {
_codes.clear();
_dict_code_converted = false;
+ _dict.clear_hash_values();
Review Comment:
```convert_dict_codes_if_necessary``` may change code order, so we need to
reset every time.
Of course, we can solve it but this may introduce additional complexity.
I didn't see the significant performance improvement in tpcds-q60 even not
clear here, this may need further research.
Currently I prefer to keep status quo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
