morningman commented on code in PR #8764:
URL: https://github.com/apache/incubator-doris/pull/8764#discussion_r857141396
##########
be/src/common/config.h:
##########
@@ -729,6 +729,7 @@ CONF_String(rpc_load_balancer, "rr");
// so we set a soft limit, default is 1MB
CONF_mInt32(string_type_length_soft_limit_bytes, "1048576");
+CONF_Int32(object_pool_buffer_size, "100");
Review Comment:
Add comment for this new config
##########
be/src/common/object_pool.h:
##########
@@ -54,6 +54,10 @@ class ObjectPool {
for (Element& elem : _objects) elem.delete_fn(elem.obj);
_objects.clear();
}
+
+ uint64_t size() {
Review Comment:
Need a `std::lock_guard<SpinLock> l(_lock);`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
