zclllyybb commented on code in PR #41739:
URL: https://github.com/apache/doris/pull/41739#discussion_r1797603709
##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -115,12 +115,9 @@ struct StrToDate {
ColumnPtr argument_columns[2] = {
col_const[0] ? static_cast<const
ColumnConst&>(*col0).convert_to_full_column()
: col0};
- check_set_nullable(argument_columns[0], null_map, col_const[0]);
Review Comment:
for this struct, u can see `static constexpr auto name = "str_to_date";`
so make sure the functions have enough testcases too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
