amorynan commented on code in PR #39932: URL: https://github.com/apache/doris/pull/39932#discussion_r1797638976
########## be/CMakeLists.txt: ########## @@ -69,6 +69,9 @@ endif() # enable glog custom prefix add_definitions(-DGLOG_CUSTOM_PREFIX_SUPPORT) +# enable simdjson check eof +add_definitions(-DSIMDJSON_CHECK_EOF) Review Comment: if we do not add this, we should check in our logic for input string buffer which has error ending -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
