morrySnow commented on code in PR #41913:
URL: https://github.com/apache/doris/pull/41913#discussion_r1804735922
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3809,4 +3835,113 @@ public LogicalPlan visitShowConfig(ShowConfigContext
ctx) {
}
return command;
}
+
+ @Override
+ public SetOptionsCommand visitSetOptions(SetOptionsContext ctx) {
+ List<SetVarOp> setVarOpList = new ArrayList<>(1);
+ for (Object child : ctx.children) {
+ if (child instanceof RuleNode) {
+ setVarOpList.add((SetVarOp) ((RuleNode) child).accept(this));
Review Comment:
maybe could use `typedVisit`
```
setVarOpList.add(typedVisit((RuleNode) child));
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3809,4 +3835,113 @@ public LogicalPlan visitShowConfig(ShowConfigContext
ctx) {
}
return command;
}
+
+ @Override
+ public SetOptionsCommand visitSetOptions(SetOptionsContext ctx) {
+ List<SetVarOp> setVarOpList = new ArrayList<>(1);
+ for (Object child : ctx.children) {
+ if (child instanceof RuleNode) {
+ setVarOpList.add((SetVarOp) ((RuleNode) child).accept(this));
+ }
+ }
+ return new SetOptionsCommand(setVarOpList);
+ }
+
+ @Override
+ public SetSessionVarOp visitSetSystemVariable(SetSystemVariableContext
ctx) {
Review Comment:
```suggestion
public SetVarOp visitSetSystemVariable(SetSystemVariableContext ctx) {
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -3809,4 +3835,113 @@ public LogicalPlan visitShowConfig(ShowConfigContext
ctx) {
}
return command;
}
+
+ @Override
+ public SetOptionsCommand visitSetOptions(SetOptionsContext ctx) {
+ List<SetVarOp> setVarOpList = new ArrayList<>(1);
+ for (Object child : ctx.children) {
+ if (child instanceof RuleNode) {
+ setVarOpList.add((SetVarOp) ((RuleNode) child).accept(this));
+ }
+ }
+ return new SetOptionsCommand(setVarOpList);
+ }
+
+ @Override
+ public SetSessionVarOp visitSetSystemVariable(SetSystemVariableContext
ctx) {
+ SetType type = SetType.DEFAULT;
+ if (ctx.GLOBAL() != null) {
+ type = SetType.GLOBAL;
+ } else if (ctx.LOCAL() != null || ctx.SESSION() != null) {
+ type = SetType.SESSION;
+ }
+ String name = stripQuotes(ctx.identifier().getText());
+ Expression expression = ctx.expression() != null ?
typedVisit(ctx.expression()) : NullLiteral.INSTANCE;
+ return new SetSessionVarOp(type, name, expression);
+ }
+
+ @Override
+ public SetSessionVarOp visitSetVariableWithType(SetVariableWithTypeContext
ctx) {
Review Comment:
```suggestion
public SetVarOp visitSetVariableWithType(SetVariableWithTypeContext ctx)
{
```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/SetOptionsCommand.java:
##########
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.RedirectStatus;
+import org.apache.doris.analysis.SetType;
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.SetLdapPassVarOp;
+import org.apache.doris.nereids.trees.plans.commands.info.SetPassVarOp;
+import org.apache.doris.nereids.trees.plans.commands.info.SetVarOp;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import java.util.List;
+
+/**
+ * SetOptionsCommand
+ */
+public class SetOptionsCommand extends Command implements ForwardWithSync {
Review Comment:
in `StmtExecutor#L707`, we use `instance of Forward` to decide whether to
forward to master. we should use toRedirectStatus result decide it.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/SetOptionsCommand.java:
##########
@@ -0,0 +1,105 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.trees.plans.commands;
+
+import org.apache.doris.analysis.RedirectStatus;
+import org.apache.doris.analysis.SetType;
+import org.apache.doris.analysis.StmtType;
+import org.apache.doris.nereids.trees.plans.PlanType;
+import org.apache.doris.nereids.trees.plans.commands.info.SetLdapPassVarOp;
+import org.apache.doris.nereids.trees.plans.commands.info.SetPassVarOp;
+import org.apache.doris.nereids.trees.plans.commands.info.SetVarOp;
+import org.apache.doris.nereids.trees.plans.visitor.PlanVisitor;
+import org.apache.doris.qe.ConnectContext;
+import org.apache.doris.qe.StmtExecutor;
+
+import java.util.List;
+
+/**
+ * SetOptionsCommand
+ */
+public class SetOptionsCommand extends Command implements ForwardWithSync {
Review Comment:
```suggestion
public class SetOptionsCommand extends Command implements Forward {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
