This is an automated email from the ASF dual-hosted git repository.
morningman pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 2dd1704e0da [Fix](orc-reader) Fix StringRef nullptr data by add
checking string_values empty. (#42061)
2dd1704e0da is described below
commit 2dd1704e0da81b1341f32432a1bebe9f5e424eb2
Author: Qi Chen <[email protected]>
AuthorDate: Mon Oct 21 12:30:40 2024 +0800
[Fix](orc-reader) Fix StringRef nullptr data by add checking string_values
empty. (#42061)
## Proposed changes
Added solution to #40857, fix StringRef nullptr data by add checking
string_values empty in orc reader.
---
be/src/vec/exec/format/orc/vorc_reader.cpp | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/be/src/vec/exec/format/orc/vorc_reader.cpp
b/be/src/vec/exec/format/orc/vorc_reader.cpp
index 7c05f934bd5..761ddf3a5f9 100644
--- a/be/src/vec/exec/format/orc/vorc_reader.cpp
+++ b/be/src/vec/exec/format/orc/vorc_reader.cpp
@@ -1184,7 +1184,9 @@ Status
OrcReader::_decode_string_non_dict_encoded_column(const std::string& col_
}
}
}
- data_column->insert_many_strings(&string_values[0], num_values);
+ if (!string_values.empty()) {
+ data_column->insert_many_strings(&string_values[0], num_values);
+ }
return Status::OK();
}
@@ -1288,8 +1290,10 @@ Status
OrcReader::_decode_string_dict_encoded_column(const std::string& col_name
}
}
}
- data_column->insert_many_strings_overflow(&string_values[0],
string_values.size(),
- max_value_length);
+ if (!string_values.empty()) {
+ data_column->insert_many_strings_overflow(&string_values[0],
string_values.size(),
+ max_value_length);
+ }
return Status::OK();
}
@@ -2402,7 +2406,9 @@ MutableColumnPtr
OrcReader::_convert_dict_column_to_string_column(
}
}
}
- res->insert_many_strings_overflow(&string_values[0], num_values,
max_value_length);
+ if (!string_values.empty()) {
+ res->insert_many_strings_overflow(&string_values[0], num_values,
max_value_length);
+ }
return res;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
