github-actions[bot] commented on code in PR #41782:
URL: https://github.com/apache/doris/pull/41782#discussion_r1808184646
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2188,4 +2188,238 @@ std::pair<MetaServiceCode, std::string>
MetaServiceImpl::get_instance_info(
return {code, std::move(msg)};
}
+MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string
cloud_unique_id_str,
Review Comment:
warning: function 'fix_tablet_stats' has cognitive complexity of 53
(threshold 50) [readability-function-cognitive-complexity]
```cpp
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string
cloud_unique_id_str,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service.cpp:2200:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
} catch (...) {
^
```
**cloud/src/meta-service/meta_service.cpp:2207:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (instance_id.empty()) {
^
```
**cloud/src/meta-service/meta_service.cpp:2218:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2236:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
do {
^
```
**cloud/src/meta-service/meta_service.cpp:2238:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2244:** +2, including nesting
penalty of 1, nesting level increased to 2
```cpp
while (it->has_next()) {
^
```
**cloud/src/meta-service/meta_service.cpp:2251:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (out.size() == 7) {
^
```
**cloud/src/meta-service/meta_service.cpp:2268:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (code != MetaServiceCode::OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2291:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (!tablet_stat.SerializeToString(&tablet_stat_value)) {
^
```
**cloud/src/meta-service/meta_service.cpp:2324:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2338:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tablet_stat_check.DebugString() !=
tablet_stat.DebugString()) {
^
```
**cloud/src/meta-service/meta_service.cpp:2349:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2358:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tablet_stat_data_size_value.size() !=
sizeof(tablet_stat_data_size_check))
^
```
**cloud/src/meta-service/meta_service.cpp:2368:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if constexpr (std::endian::native == std::endian::big) {
^
```
**cloud/src/meta-service/meta_service.cpp:2375:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (tablet_stat_data_size_check != tablet_stat_data_size) {
^
```
**cloud/src/meta-service/meta_service.cpp:2385:** +3, including nesting
penalty of 2, nesting level increased to 3
```cpp
if (sub_txn_id % 50 == 0) {
^
```
**cloud/src/meta-service/meta_service.cpp:2387:** +4, including nesting
penalty of 3, nesting level increased to 4
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2393:** +1, nesting level
increased to 4
```cpp
} else {
^
```
**cloud/src/meta-service/meta_service.cpp:2405:** +1, including nesting
penalty of 0, nesting level increased to 1
```cpp
if (err != TxnErrorCode::TXN_OK) {
^
```
**cloud/src/meta-service/meta_service.cpp:2413:** +1, nesting level
increased to 1
```cpp
} else {
^
```
</details>
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -2188,4 +2188,238 @@
return {code, std::move(msg)};
}
+MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string
cloud_unique_id_str,
Review Comment:
warning: function 'fix_tablet_stats' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string
cloud_unique_id_str,
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service.cpp:2190:** 231 lines including
whitespace and comments (threshold 80)
```cpp
MetaServiceResponseStatus MetaServiceImpl::fix_tablet_stats(std::string
cloud_unique_id_str,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
