zhiqiang-hhhh commented on code in PR #42136:
URL: https://github.com/apache/doris/pull/42136#discussion_r1810312465
##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -34,10 +34,16 @@
namespace doris::vectorized {
+const static std::string DECIMAL256_FUNCTION_SUFFIX {"_decimal256"};
Review Comment:
This static var should be moved to a cpp file and it should have global
visibility.
Just leave `extern std::string DECIMAL256_FUNCTION_SUFFIX` in header file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
