gavinchou commented on code in PR #41818:
URL: https://github.com/apache/doris/pull/41818#discussion_r1814335520
##########
be/src/io/cache/block_file_cache.h:
##########
@@ -446,6 +489,9 @@ class BlockFileCache {
LRUQueue _disposable_queue;
LRUQueue _ttl_queue;
+ // keys for async remove
+ std::shared_ptr<boost::lockfree::spsc_queue<FileCacheKey>> _recycle_keys;
Review Comment:
it seems there is no contention on _recycle_keys.
it is better to use regular data structure instead for better understanding
and maintainance
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
