morningman commented on code in PR #9280:
URL: https://github.com/apache/incubator-doris/pull/9280#discussion_r860488500
##########
gensrc/proto/internal_service.proto:
##########
@@ -104,6 +105,28 @@ message PTabletWriterAddBatchRequest {
optional bool is_high_priority = 11 [default = false];
};
+message PTabletWriterAddBlockRequest {
+ required PUniqueId id = 1;
+ required int64 index_id = 2;
+ required int32 sender_id = 3;
+
+ // If this is the last batch from this sender
+ optional bool eos = 4;
+
+ required int64 packet_seq = 5;
Review Comment:
Use `optional` for all fields
##########
be/src/olap/delta_writer.h:
##########
@@ -97,13 +99,13 @@ class DeltaWriter {
void _reset_mem_table();
-private:
bool _is_init = false;
bool _is_cancelled = false;
WriteRequest _req;
TabletSharedPtr _tablet;
RowsetSharedPtr _cur_rowset;
std::unique_ptr<RowsetWriter> _rowset_writer;
+ // TODO: Recheck the lifttime of _mem_table, Look only should use
unique_ptr
Review Comment:
```suggestion
// TODO: Recheck the lifetime of _mem_table, Look only should use
unique_ptr
```
##########
be/src/olap/olap_define.h:
##########
@@ -56,6 +56,9 @@ static const uint16_t OLAP_VARCHAR_MAX_LENGTH = 65535;
// the max length supported for string type 2GB
static const uint32_t OLAP_STRING_MAX_LENGTH = 2147483647;
+// the max length supported for vec string type 1MB
+static constexpr size_t MAX_SIZE_OF_VEC_STRING = 1024 * 1024;
Review Comment:
I remember that we support 10MB？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
