github-actions[bot] commented on code in PR #42693:
URL: https://github.com/apache/doris/pull/42693#discussion_r1820172149
##########
be/src/vec/functions/function_datetime_floor_ceil.cpp:
##########
@@ -332,8 +331,8 @@ struct FloorCeilImpl {
}
}
}
- template <typename NativeType, typename DeltaType>
- static void vector_const_const(const PaddedPODArray<NativeType>& dates,
const DeltaType period,
+ template <typename NativeType>
+ static void vector_const_const(const PaddedPODArray<NativeType>& dates,
const Int32 period,
Review Comment:
warning: function 'vector_const_const' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
static void vector_const_const(const PaddedPODArray<NativeType>& dates,
const Int32 period,
^
```
<details>
<summary>Additional context</summary>
**be/src/vec/functions/function_datetime_floor_ceil.cpp:334:** 82 lines
including whitespace and comments (threshold 80)
```cpp
static void vector_const_const(const PaddedPODArray<NativeType>& dates,
const Int32 period,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
