Jibing-Li commented on code in PR #42921:
URL: https://github.com/apache/doris/pull/42921#discussion_r1823699564
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/hive/HMSExternalTable.java:
##########
@@ -863,14 +865,20 @@ private long getRowCountFromFileList() {
estimatedRowSize += column.getDataType().getSlotSize();
}
if (estimatedRowSize == 0) {
+ LOG.warn("Table {} estimated size is 0, return 0.", name);
return 0;
}
int totalPartitionSize = partitionValues == null ? 1 :
partitionValues.getIdToPartitionItem().size();
if (samplePartitionSize != 0 && samplePartitionSize <
totalPartitionSize) {
+ LOG.info("Table {} sampled {} of {} partitions, sampled size is
{}",
+ name, samplePartitionSize, totalPartitionSize, totalSize);
totalSize = totalSize * totalPartitionSize / samplePartitionSize;
}
- return totalSize / estimatedRowSize;
+ long rows = totalSize / estimatedRowSize;
+ LOG.info("Table {} rows {}, total size is {}, estimatedRowSize is {}",
Review Comment:
This function is only called while loading the cache, will not print this
log after cache is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
