github-actions[bot] commented on code in PR #42413:
URL: https://github.com/apache/doris/pull/42413#discussion_r1824386758
##########
cloud/src/meta-service/meta_service_http.cpp:
##########
@@ -331,6 +338,122 @@ static HttpResponse process_alter_iam(MetaServiceImpl*
service, brpc::Controller
return http_json_reply(resp.status());
}
+static HttpResponse process_adjust_rate_limit(MetaServiceImpl* service,
brpc::Controller* cntl) {
Review Comment:
warning: function 'process_adjust_rate_limit' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
static HttpResponse process_adjust_rate_limit(MetaServiceImpl* service,
brpc::Controller* cntl) {
^
```
<details>
<summary>Additional context</summary>
**cloud/src/meta-service/meta_service_http.cpp:340:** 90 lines including
whitespace and comments (threshold 80)
```cpp
static HttpResponse process_adjust_rate_limit(MetaServiceImpl* service,
brpc::Controller* cntl) {
^
```
</details>
##########
cloud/test/meta_service_http_test.cpp:
##########
@@ -1454,4 +1454,94 @@ TEST(MetaServiceHttpTest, TxnLazyCommit) {
}
}
+TEST(MetaServiceHttpTest, AdjustRateLimit) {
+ HttpContext ctx;
+ {
+ auto [status_code, content] =
+ ctx.query<std::string>("adjust_rate_limit", "qps_limit=10000");
+ ASSERT_EQ(status_code, 200);
+ }
+ {
+ auto [status_code, content] =
Review Comment:
warning: function 'TEST' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
}
^
```
<details>
<summary>Additional context</summary>
**cloud/test/meta_service_http_test.cpp:1464:** 82 lines including
whitespace and comments (threshold 80)
```cpp
}
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
