xiaokang commented on code in PR #42697:
URL: https://github.com/apache/doris/pull/42697#discussion_r1825725922
##########
be/src/service/internal_service.cpp:
##########
@@ -886,13 +886,10 @@ void
PInternalService::fetch_arrow_flight_schema(google::protobuf::RpcController
Status PInternalService::_tablet_fetch_data(const PTabletKeyLookupRequest*
request,
PTabletKeyLookupResponse*
response) {
- PointQueryExecutor lookup_util;
- RETURN_IF_ERROR(lookup_util.init(request, response));
- RETURN_IF_ERROR(lookup_util.lookup_up());
- if (VLOG_DEBUG_IS_ON) {
- VLOG_DEBUG << lookup_util.print_profile();
- }
- LOG_EVERY_N(INFO, 500) << lookup_util.print_profile();
+ PointQueryExecutor executor;
+ RETURN_IF_ERROR(executor.init(request, response));
+ RETURN_IF_ERROR(executor.lookup_up());
+ executor.print_profile();
Review Comment:
print profile for every request?
##########
be/src/service/point_query_executor.cpp:
##########
@@ -380,6 +396,17 @@ Status PointQueryExecutor::_lookup_row_key() {
specified_rowsets = _tablet->get_rowset_by_ids(nullptr);
}
std::vector<std::unique_ptr<SegmentCacheHandle>>
segment_caches(specified_rowsets.size());
+ // init segment_cache
Review Comment:
Why add this logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
