morrySnow commented on PR #9345: URL: https://github.com/apache/incubator-doris/pull/9345#issuecomment-1117534867
> > Hi, leo65535. Great job. It's nice to see you dealing with the style of the previous code. It is important to point out that once the task start, it is best to deal with all style issues other than JavaDoc-related issues as soon as possible to minimizing the impact on code history. > > Hi @morrySnow, there are many rules, I think it's better to split them to several steps. And, it will be hard to review, please refer to [pull request](https://github.com/apache/incubator-doris/pull/9113), `File changes 1387`. Yes, `split them to several steps` is necessary. We need to fix all about them asap. The first step from you is very important. After this PR merged, we need to take apart the rest of the rules to avoid two people fixing the same rule. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
