yiguolei commented on code in PR #43065:
URL: https://github.com/apache/doris/pull/43065#discussion_r1827163287
##########
be/src/vec/data_types/serde/data_type_ipv6_serde.cpp:
##########
@@ -87,7 +87,10 @@ void DataTypeIPv6SerDe::write_one_cell_to_jsonb(const
IColumn& column,
result.writeKey(col_id);
IPv6 data = assert_cast<const ColumnIPv6&>(column).get_element(row_num);
IPv6Value ipv6_value(data);
- result.writeString(ipv6_value.to_string());
+ std::string ipv6_str = ipv6_value.to_string();
Review Comment:
it may cost too much
Could ipv6 value return StringRef directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
